Quality pass: configuration & settings#88
Merged
dhilgaertner merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
Refactor, validate, document, and test the config/settings subsystem. - Extract shared AppSupportDirectory for rm-ai-ide migration (was duplicated in ConfigStore and JSONStore) - Consolidate WorkspaceEditorView and WorkspaceFormSheet into WorkspaceFormView - Add workspace name validation (empty, duplicate, filesystem-unsafe chars) - Add branch prefix validation against git-ref-format rules - Add derivedCLI computed property to WorkspaceInfo - Log config decode/save errors instead of silently swallowing with try? - Set 0o700 permissions on .claude/ directory (was only setting file perms) - Add Equatable conformance to AppConfig and its nested types - Add documentation to models and ConfigStore - Add 31 new tests across CrowCore and CrowPersistence packages Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dhilgaertner
force-pushed
the
feature/crow-67-config-settings-quality
branch
from
16b0bc2 to
a400d60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppSupportDirectoryfor rm-ai-ide migration (was duplicated in ConfigStore and JSONStore)WorkspaceEditorViewandWorkspaceFormSheetinto sharedWorkspaceFormViewderivedCLIcomputed property, error logging in ConfigStore/AppDelegate, 0o700 permissions on.claude/directoryTest plan
make buildcompiles cleanlyswift test --package-path Packages/CrowCore— 26 tests passswift test --package-path Packages/CrowPersistence— 5 tests passCloses #67
🤖 Generated with Claude Code